Skip to content

adding doctests to maths/trapezoidal_rule.py#12193

Merged
tianyizheng02 merged 10 commits into
TheAlgorithms:masterfrom
Miranda13:features/julian
Dec 28, 2024
Merged

adding doctests to maths/trapezoidal_rule.py#12193
tianyizheng02 merged 10 commits into
TheAlgorithms:masterfrom
Miranda13:features/julian

Conversation

@MRJPEREZR

@MRJPEREZR MRJPEREZR commented Oct 19, 2024

Copy link
Copy Markdown
Contributor

Describe your change:

Contributes to #9943

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@MRJPEREZR

MRJPEREZR commented Oct 19, 2024

Copy link
Copy Markdown
Contributor Author

Adding doctests to improve test coverage of maths/trapezoidal_rule.py from 18% to 75%.

@MRJPEREZR
MRJPEREZR marked this pull request as draft October 19, 2024 19:10
@MRJPEREZR
MRJPEREZR marked this pull request as ready for review October 19, 2024 19:11
@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 19, 2024
@MRJPEREZR
MRJPEREZR marked this pull request as draft October 23, 2024 09:12
@MRJPEREZR

MRJPEREZR commented Oct 23, 2024

Copy link
Copy Markdown
Contributor Author

Hello @cclauss , excuse me, I was reviewing the last merged PR associated to issue #9943 and I found you as frequent reviewer to this kind of PR. I would like to know if you could help me with your approve to merge this PR. We are a group of students that we want to contribute to this project, so in the following days, it will be some others similar PR like this. Thanks.

@MRJPEREZR
MRJPEREZR marked this pull request as ready for review October 23, 2024 09:58
@MRJPEREZR MRJPEREZR changed the title adding doctests to maths/trapezoidal_rule.py adding doctests to maths/trapezoidal_rule.py #9943 Nov 6, 2024
@MRJPEREZR MRJPEREZR changed the title adding doctests to maths/trapezoidal_rule.py #9943 adding doctests to maths/trapezoidal_rule.py Nov 6, 2024
@MRJPEREZR

MRJPEREZR commented Nov 6, 2024

Copy link
Copy Markdown
Contributor Author

Hi @tianyizheng02,

Sorry for tagging you, but I wanted to ask if it would be possible to review and accept this PR. I know the issue is a bit old (it was opened in October 2023), but we’re a group of students working on a small project, and I thought contributing to issues like these, where tests are needed, would be valuable.

Best regards!

@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Nov 7, 2024
@algorithms-keeper algorithms-keeper Bot removed the tests are failing Do not merge until tests pass label Nov 7, 2024
@tianyizheng02
tianyizheng02 merged commit 1909f22 into TheAlgorithms:master Dec 28, 2024
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Dec 28, 2024
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MRJPEREZR @tianyizheng02